ci: Split Android build from rest#2145
Conversation
|
Results from the timing added in that last commit (from this log): analyze elapsed time: 0m34.9s Total time for the tools/check step, as reported by GitHub: 4m57s. So the The main downside of splitting up the jobs more finely is the setup time for each job. In that same log, the setup steps take 1s + 1s + 1s + 17s + 28s + 8s (the longest being |
|
Meanwhile the |
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks @gnprice. All LGTM, please merge at will.
| # This logic relies on suite names having no spaces nor glob characters. | ||
| suites_str=" ${opt_suites[*]} " | ||
| for suite in "${opt_exclude[@]}"; do | ||
| suites_str="${suites_str/ "$suite" / }" |
| android: | ||
| name: "Android build and lint" | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Cool. We may do something similar for iOS builds in CI, where the Actions job will run on macos image instead.
There was a problem hiding this comment.
Yeah. That's #773 — probably a good idea to do that soon, given the work you're doing that adds more iOS code. I've moved it up to this milestone (was in the upcoming M9).
This gives us one fewer place to update each time we add or rename a suite.
This will help us with splitting our CI into multiple jobs, without having to list all the suites explicitly in the CI script.
The Android build takes much longer than the whole rest of our CI. It'd therefore be good to split them up as separate jobs, in particular so that we can get a result from the rest of our suites sooner.
In particular this will help guide us in optimizing the way our CI is arranged.
|
Thanks for the review! Merged. |
2 participants
The Android build takes much longer than the whole rest of our CI. It'd be good to split them up as separate jobs, in particular so that we can get a result from the rest of our suites sooner.
(This PR is starting as a draft in order to experiment with how it behaves in CI.)OK, ready now.